sql: remove epoch info query cache #6575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The epoch info query cache mechanism contains a hard-to-fix deadlock, possibly due to a recursive RLock() on an RWMutex. Moreover, due to an oversight, in the default fetcher mode (streaming) epoch query cache is not actually being used, while the cached slice update calls which are causing deadlock are still being made upon adding each new ATX. With syncv2, epoch info cache will no longer be needed at all, and with current network size, it isn't very useful either. This change removes epoch query cache, keeping blob query cache for now.
ivan4th
requested review from
dshulyak,
fasmat,
poszu,
acud,
jellonek and
kacpersaw
as code owners
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #6575 +/- ##
=========================================
- Coverage 79.7% 79.7% -0.1%
=========================================
Files 355 355
Lines 47168 47097 -71
=========================================
- Hits 37620 37561 -59
+ Misses 7404 7394 -10
+ Partials 2144 2142 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The epoch info query cache mechanism contains a hard-to-fix deadlock, possibly due to a recursive RLock() on an RWMutex. Moreover, due to an oversight, in the default fetcher mode (streaming) epoch query cache is not actually being used, while the cached slice update calls which are causing deadlock are still being made upon adding each new ATX.
With syncv2, epoch info cache will no longer be needed at all, and with current network size, it isn't very useful either.
Description
This change removes epoch query cache, keeping blob query cache for now.
Test Plan
Make sure tests pass, including systests.